Fix #2818 #4358
Merged
Fix #2818 #4358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for apollo-android-docs pending review.Visit the deploys page to approve it
|
BoD
approved these changes
Aug 26, 2022
Contributor
BoD
left a comment
BoD
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks a lot 🙏
| .build() | ||
| .await() | ||
|
|
||
| assertThat(cacheResponse.data?.home?.sectionA?.name).isEqualTo("modifiedSectionName") |
Contributor
There was a problem hiding this comment.
Can you also add a check that the fragment is correctly written?
Suggested change
| assertThat(cacheResponse.data?.home?.sectionA?.name).isEqualTo("modifiedSectionName") | |
| assertThat(cacheResponse.data?.home?.sectionA?.name).isEqualTo("modifiedSectionName") | |
| assertThat(cacheResponse.data?.home?.fragments?.sectionFragment?.sectionA?.imageUrl).isEqualTo("modifiedUrl") |
Contributor
martinbonnin
left a comment
martinbonnin
left a comment
There was a problem hiding this comment.
A small comment but looks good to me, thanks!
martinbonnin
approved these changes
Aug 29, 2022
Contributor
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the suggestion from here:
Also added an integration test based on the reproducer, as suggested by @BoD (thank you!).